Closed nasib-ullah closed 3 weeks ago
Thanks for pointing this out. This looks the right way to go. However, there seems to be mismatch in precision - one the left side it is 32 bit precision (with np.int32_t) and 64 bit on the right side (with 'int'). We can possibly make the indices 64 bits on both sides?
You're absolutely right about the precision mismatch. I've updated the code to use np.int64_t and dtype=np.int64 to ensure that the indices are 64-bit integers on both sides. Thanks
Thanks! Merged.
When trying to install pyxclib using pip with latest NumPy version, the following error occurs during compilation:
This error seems to be caused by the use of
np.int_t
, which is no longer supported in newer NumPy versions.Environment details:
Proposed solution: Replace
np.int_t
withnp.intp_t
in the affected files, particularly inxclib/utils/_sparse.pyx
. This should resolve the compilation issue while maintaining compatibility across different platforms.Steps to reproduce:
pip install git+https://github.com/kunaldahiya/pyxclib
Please review the changes and let me know if any further modifications are needed.