search

kunalnagarco / action-cve

A GitHub action that sends Dependabot Vulnerability Alerts to Slack, PagerDuty, Zenduty, Microsoft Teams.
https://github.com/marketplace/actions/check-cve
MIT License
20 stars 20 forks source link

feat: Add filter by manifest #152

Closed joris974 closed 1 week ago

joris974 commented 5 months ago

Adding a filter by manifest is quite useful when working in a monorepo.

(Not tested if this is working as intended)

kunalnagar commented 5 months ago

@joris974 - the PR looks great!

I tried testing it with some manifest values and I'm not sure it's working as intended. I don't think it's a problem with your code, I just think it's how the GitHub API handles this.

I entered a random value for manifest like: asdasdasd and it still returned a list of vulns. I would assume if would not return anything since this is an invalid value?

Do you mind running a few tests on some repos and post them here so we can validate? Thanks! Once we are confident on what is the expected behaviour, we can get the PR in and update the wiki as well. Thanks for the contribution :slightly_smiling_face:

image

joris974 commented 5 months ago

@joris974 - did you get a chance to test the manifest param?

Sorry, I didn't have time to work on this.