search

kunalnagarco / action-cve

A GitHub action that sends Dependabot Vulnerability Alerts to multiple sources.
https://github.com/marketplace/actions/check-cve
MIT License
24 stars 22 forks source link

feat: Add filter by ecosystem #184

Closed romkaspb closed 4 months ago

romkaspb commented 4 months ago

Good day @kunalnagar, thank you for your work.

While in our project we have monorepository, we need the feature to run action for different ecosystems. I made some changes and it works like a charm.

I know that it's not ready-to-merge PR, but maybe we can prepare it together? I'm not a JS developer btw :)

romkaspb commented 4 months ago

I tried to add ecosystem filter looking into PR with manifest filter - FYI

romkaspb commented 4 months ago

Hey @kunalnagar,

  1. I can but there are no changes in output. We can change text to something like You have ${alertCount} vulnerabilities in *${repoName}* for ${ecosystem} ecosystem. What do you think?
  2. Yep I will. And I will squash commits when we will be going to merge it.
kunalnagar commented 4 months ago
  1. We can change text to something like

I think let's keep the existing text as I see this getting longer as more fields are added. This gave me an idea for a feature -- customize what columns/fields should be shown in the alert that gets sent out. Ecosystem could be one of those fields.

And I will squash commits

Thanks. You can go ahead and merge.

romkaspb commented 4 months ago

@kunalnagar did squash and changed PR title. I don't have permissions to merge PR.

github-actions[bot] commented 4 months ago

:tada: This PR is included in version 1.13.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: