kundajelab / bpnet

Toolkit to train base-resolution deep neural networks on functional genomics data and to interpret them
http://bit.ly/bpnet-colab
MIT License
141 stars 33 forks source link

bpnet export-bw skips contribution.bw file writing #6

Closed mlweilert closed 4 years ago

mlweilert commented 4 years ago

In bpnet.BPNet.export_bw def on lines 422-424, the assertion fails when you try to run bpnet export-bw on a trained model, skipping all writing steps to the contrib.bw files.

Avsecz commented 4 years ago

You are right. Thanks for pointing this out. Can you try replacing if with if not on line 423 https://github.com/kundajelab/bpnet/blob/0cba2515c15589f8439876c3028ce177544ee9cb/bpnet/BPNet.py#L423?

mlweilert commented 4 years ago

tested it and it works fine! Just committed the change!