Type error in modisco cwm-scan

kundajelab / bpnet

Toolkit to train base-resolution deep neural networks on functional genomics data and to interpret them

http://bit.ly/bpnet-colab

MIT License

142 stars 35 forks source link

Type error in modisco cwm-scan #7

Closed mmtrebuchet closed 4 years ago

mmtrebuchet commented 4 years ago

On line 550 of cli/modisco.py (commit db8908), there's a check for the output file name's suffix. I get an error that posix_path doesn't have a .endswith method. Can you confirm that output_file is the expected type here?

Avsecz commented 4 years ago

I think I fixed the issue. Try to re-run with the most recent branch. Feel free to re-open if the issue still persists.