kundajelab / chrombpnet

Bias factorized, base-resolution deep learning models of chromatin accessibility (chromBPNet)
https://github.com/kundajelab/chrombpnet/wiki
MIT License
124 stars 34 forks source link

Nit: Small inconsistency on "Generate contribution score bigwigs" wiki page for names of output files #181

Closed KnightAsterial closed 8 months ago

KnightAsterial commented 9 months ago

On the wiki page for generating contributions cores, the outputs for count scores are listed as output_prefix.count_scores.h5 https://github.com/kundajelab/chrombpnet/wiki/Generate-contribution-score-bigwigs

However, in the code they are generated as args_copy.output_prefix + ".counts_scores.h5" (counts instead of count) https://github.com/kundajelab/chrombpnet/blob/master/chrombpnet/CHROMBPNET.py#L65

panushri25 commented 8 months ago

Ah thanks for catching the typo!