search

kundajelab / dragonn

A toolkit to learn how to model and interpret regulatory sequence data using deep learning.
http://kundajelab.github.io/dragonn/
MIT License
254 stars 71 forks source link

typo in hyperparameter_search.py #45

Closed kiminsigne-ucla closed 6 years ago

kiminsigne-ucla commented 6 years ago

I believe there is a typo in the __init__ function for class HyperparameterSearcher. The default metric='auPRG' should be metric='auPRC'. I was running the simple_motif_detection.py script and received this key error:

Traceback (most recent call last):
  File "simple_motif_finding.py", line 89, in <module>
    searcher.search(num_hyperparameter_trials)
  File "build/bdist.macosx-10.9-x86_64/egg/dragonn/hyperparameter_search.py", line 117, in search
  File "build/bdist.macosx-10.9-x86_64/egg/dragonn/models.py", line 36, in score
  File "build/bdist.macosx-10.9-x86_64/egg/dragonn/metrics.py", line 73, in __getitem__
KeyError: 'auPRG'
jisraeli commented 6 years ago

spot on. would you be willing to open PR with fix? would love to get more people contributing before I graduate (soon) :)

jisraeli commented 6 years ago

Fixed in #46 - thank you!