Closed karl616 closed 6 years ago
In order to this, a license is needed. Is this something you have thought about?
Good point. We'll add the license info to the GitHub.
On Tue, Jul 31, 2018, 5:38 AM Karl Nordström notifications@github.com wrote:
In order to this, a license is needed. Is this something you have thought about?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kundajelab/phantompeakqualtools/issues/10#issuecomment-409205952, or mute the thread https://github.com/notifications/unsubscribe-auth/AAI7EaCdXOImcPzwf9dDgXea6JfOXG2cks5uME_UgaJpZM4VjeAy .
@karl616 Thanks for your work, just added a license file. I am still working on the installation script for pipelines let's talk there.
@leepc12 I'll try to keep my communication more centralized...
For reference, this is the pull request to add phantompeakqualtools to bioconda: https://github.com/bioconda/bioconda-recipes/pull/10171
phantompeakqualtools is now merged in and available in bioconda. With the bioconda repository correctly configured it can be installed with:
conda install phantompeakqualtools
With that I'll close this issue.
Should this be added to bioconda?
If so, how modified is the SPP version? Would it be possible to make use of the SPP already in bioconda? In your atac-seq-pipeline, you use r-spp v1.13. Is that sufficient?