search

kung-fu-panda-automotive / carla-driver

The CarND Capstone Project
8 stars 8 forks source link

Add angular velocity calculation (Fixes #23) #25

Closed mauricelos closed 7 years ago

asimonov commented 7 years ago

I see Kostas approved this PR from the beach, so I will step away :)

My comments would be:

  1. we should document input/output types for functions we touch
  2. we shall start thinking about creating unit tests as we go along
  3. until we actually use unit tests we can at least place 'assert' everywhere we rely on some invariant