search

kungfoo / geohash-java

Implementation of GeoHashes in java. We try to be/stay compliant to the spec, as far as possible.
Other
981 stars 310 forks source link

change ord to use unsigned >>> shift #20

Closed aborochoff closed 9 years ago

aborochoff commented 9 years ago

Change the right shift to unsigned. Binary geohash should never be negative / two's compliment breaks it.

Repro -> geo = GeoHash(-36.919550434870125,174.71024582237604,7)

aborochoff commented 9 years ago

https://docs.oracle.com/javase/tutorial/java/nutsandbolts/op3.html

kungfoo commented 9 years ago

I merged this.

aborochoff commented 9 years ago

thanks!

kungfoo commented 9 years ago

I did a release including this fix of 1.1.0 to OSSRH, it might take a few minutes for it to show up in maven central. Thanks for pointing it out! (y)