search

kungfoo / geohash-java

Implementation of GeoHashes in java. We try to be/stay compliant to the spec, as far as possible.
Other
982 stars 310 forks source link

Made data classes Serializable #6

Closed ktcorby closed 13 years ago

ktcorby commented 13 years ago

Hi, I have another pull request. This one is very minor. I made most of the data classes Serializable.

Thanks, Kevin

kungfoo commented 13 years ago

This would however force us to define a serial version id and/or to define out custom serialization functions, right?

ktcorby commented 13 years ago

You are right, I should have added serialVersionUIDs. I did that now. Unfortunately my IDE also reformatted some whitespace, so the diff is bigger than it should be. If you have any heartburn about these classes being serializable I can just keep it on my own fork, but its useful for me.

Thanks.

kungfoo commented 13 years ago

Why would you use spaces instead of tabs in java? :D

Anyway, as far as I see the default serialization should work without problems for these classes, so we need not add the very special shiny magic methods that do manual serialization. I'll merge it, but my IDE will probably reformat as well...

ktcorby commented 13 years ago

Regarding spaces vs. tabs, all I can say is ask the IntelliJ developers.