search

kungfu-king-betty / cordova-plugin-native-app-update

This is a cordova plugin to easily check the iOS App Store or Android Google Play Store for an available app update.
MIT License
12 stars 17 forks source link

Non-void function does not return a value - XCode #2

Closed media4learning closed 3 years ago

media4learning commented 3 years ago

Your Environment

Expected Behavior

Building project in XCode I get the error 'Non-void function does not return a value' line 68 in CDVAppUpdate.m

Actual Behavior

Should return a value? Or compile/build

Steps to Reproduce

  1. Create capacitor 3 project and add ios platform
  2. npm i cordova-plugin-native-app-update
  3. npx cap sync
  4. npx cap open ios
  5. Select run / build. Build fails

Context

Use plugin to check for app update on app store. I understand I'm not using this in a cordova project but Capacitor supports Cordova plugins. I suspect the needsUpdate method just needs to return a boolean?

Screenshot 2021-05-14 at 3 27 09 PM

Debug logs

kungfu-king-betty commented 3 years ago

Hello media! I appreciate you providing so much detail in your issue description, it made tracking down the problem much easier!

Version 1.0.3 was just released, which fixes this issue, so just need to update the plugin and you should be all set. Please let me know if you still have an issue or run into any other problems, thanks!

media4learning commented 3 years ago

Hello media! I appreciate you providing so much detail in your issue description, it made tracking down the problem much easier!

Version 1.0.3 was just released, which fixes this issue, so just need to update the plugin and you should be all set. Please let me know if you still have an issue or run into any other problems, thanks!

Thanks! I can now build my project, Appreciate your work.