kungfuai / d3m-primitives

Apache License 2.0
2 stars 6 forks source link

Please do not name your python module "primitives" #14

Closed mitar closed 4 years ago

mitar commented 4 years ago

This is making them fail to load in my TA2 system. It is too generic. So you should name your python module similar to your package. I suggest kf_d3m_primitives or something (and not primitives). So this is a bit tricky thing with Python, that package name (what you have in setup.py) is not really important, important is the directory name you are installing, currently primitives.

mitar commented 4 years ago

Fixed in https://gitlab.com/datadrivendiscovery/primitives/-/merge_requests/303.