search

kungfusheep / SublimeLinter-contrib-stylelint

this repo is no longer maintained - please see https://github.com/SublimeLinter/SublimeLinter-stylelint
MIT License
116 stars 19 forks source link

Do not rely on data.errored #49

Closed subzey closed 7 years ago

subzey commented 7 years ago

Stylelint doesn't set "errored": true in the JSON if there were only warnings, but no errors. It leads to the wrong behavior when warnings are not shown at all on a file without errors.

This results somewhat funny outcome: I had to add errors intentionally to make warnings visible.

subzey commented 7 years ago

Uh... Looks like @nwoltman was the first to send the similar PR (#45)

nwoltman commented 7 years ago

@kungfusheep *ping*

leptest commented 7 years ago

This has helped me a lot! Any chance we can get it merge in?

Thanks, Daniel

kungfusheep commented 7 years ago

Merged - sorry for the delay.

leptest commented 7 years ago

Thanks @kungfusheep and @subzey! :D

subzey commented 7 years ago

@kungfusheep Thank you! 🎆