Do not override `communicate`

kaste commented 6 years ago

Hi :wave:!

Generally, overriding communicate is discouraged. However, the current implementation is also broken.

'__RELATIVE_TO_FOLDER__' is not used directly, and since SL4 is coming really, really not necessary.
elif not code: matches the empty string. Generally, bc you use STDIN you MUST assume code is never None here. So, this whole branch should actually never match.
os.path.splitext(filename) actually returns a tuple (name, ext). So the following code throws. The author assumes here it returns just the 'ext'. (So, the correct code would be _, fileext = os.path.splitext(filename), but as I said the whole if branch should be unreachable.

Bug report https://github.com/SublimeLinter/SublimeLinter/issues/1030

braver commented 6 years ago

@kungfusheep do you perhaps want to transfer this repo to the SublimeLinter org so we have more people maintain it? To do so, please transfer this repo to me and I’ll complete the move.

braver commented 6 years ago

@kungfusheep I'm replicating this repo into the SublimeLinter org because I kinda need it personally and we would like to improve it. If you want more information about that, please let me know.

kungfusheep / SublimeLinter-contrib-stylelint

Do not override `communicate` #55