Symfony 5 Compatibility

kunicmarko20 / SonataAnnotationBundle

Annotations for Sonata Admin

MIT License

21 stars 7 forks source link

Symfony 5 Compatibility #39

Closed mathieupetrini closed 4 years ago

mathieupetrini commented 4 years ago

I am targeting this branch because master because I had to upgrade sonata-admin-bundle to is dev-master version (until release v4.0)

Changelog

### Added
- Symfony 5 Compatibility

### Removed
- Behat Tests

Subject

Symfony 5 Compatibility

lukepass commented 4 years ago

Hello, unfortunately I'm not still using Symfony 5 (all our projects are currently in 4.4). I think that compatibility with PHP 7.2 should be preserved. If you are able to fix the checks maybe we can ask @kunicmarko20 if the pull request can be merged?

Thanks.

kunicmarko20 commented 4 years ago

I would be happy to merge it, but you branched from 1.x and are trying to merge into master and that is why there are so many extra commits