kuno / GeoIP

GeoIP binding for nodejs(>=0.10) and iojs
GNU Lesser General Public License v2.1
414 stars 129 forks source link

UTF-8 characters #11

Closed TheDeveloper closed 11 years ago

TheDeveloper commented 13 years ago

We ran into an issue where UTF-8 characters were not being encoded properly. We patched it for city.cc in https://github.com/jbt/GeoIP/commit/0ead9ca293811a4bbb40f7cf94f60520bd5c997b#diff-4 but was just wondering whether you were aware of this/had plans to fix. If you can confirm the issue then I'll ask the repo owner to submit a pull request here.

kuno commented 13 years ago

hi, sorry the delay for response.

I've not had any utf-8 experience, so maybe you could offer some test scripts that dealing with utf-8 stuff to prove the code?

best-regards

--kuno