search

kuno / GeoIP

GeoIP binding for nodejs(>=0.10) and iojs
GNU Lesser General Public License v2.1
414 stars 129 forks source link

Support Node 0.11.4 #62

Closed kkoopa closed 11 years ago

kkoopa commented 11 years ago

This is a backwards-compatible patch adding support for Node 0.11.4+.

kkoopa commented 11 years ago

Now it works.

kuno commented 11 years ago

thanks, I have not take a look on the changes in 0.11.x, Would you please point me to the changelog/doc, where describe those changes?

thanks.

kkoopa commented 11 years ago

There are a million changes, none of them documented in much more than git commit messages. Best collection is the actual NAN page https://github.com/rvagg/nan where all of NAN is documented.

https://github.com/joyent/node/wiki/API-changes-between-v0.10-and-v0.12 https://github.com/joyent/node/commit/110a9cd8db515c4d1a9ac5cd8837291da7c6c5ea

kuno commented 11 years ago

So nan is the your guy's efforts to make development of native c++ addon easier?

kkoopa commented 11 years ago

Yes, precisely. The aim of the project is to provide a transition layer from 0.8 to 1.0 so you don't end up with #if NODE_MODULE_VERSION < 12 everywhere, which creates unreadable code kkoopa/contextify@561efe01121c8e238c3daadb6fa81374c058cdb2 . It will be available through npm before 0.12 comes, so it will be easier to stay up to date.

kuno commented 11 years ago

Thanks, accepted.