search

kunstler / laselva

Fetch Forest Inventory data from many countries
https://docs.ropensci.org/laselva
Other
9 stars 4 forks source link

Reviving the package #18

Open gowachin opened 1 year ago

gowachin commented 1 year ago

I'll start looking into this package. This issue is mainly to track questions about the code I don't understand etc. All edits will first take place on my fork : https://github.com/gowachin/laselva

Currently, the tests have 12 errors and 6 warnings, impossible to run a whole check. The vignette is pre-compiled according to the Ropensci method.

gowachin commented 1 year ago

Dependancy {hoardr} is archived on github (https://github.com/ropensci/hoardr) but private message with Maëlle (Ropensci) confirm it will be maintained.

gowachin commented 1 year ago

R-check

The check was not running fine on GHA. I'm working on updating the action so the check could run easily. I work on parallel with {testthat} and the "HTTP testing in R" book.

Note : the README build status is linked to ropenscilabs/laselva repository and not kunstler/laselva but this is just because the owner was modified.

gowachin commented 1 year ago

Github Action is now working fine. I don't fully understand if the tests are skipped or not but this is a good news.

Now I can edit the package.

EDIT : There was warnings, but the check is now very clean. The tests for jpn return warnings.

gowachin commented 1 year ago

No more warning during check. Solved issue #14 about jpn warnings.

gowachin commented 1 year ago

Tests are running on local :

Needed to clean the files and cassette from {vcr} for tests to run. Also need to set error in english for correct language in stop errors. Using {checkmate} may simplify the testing part and remove these tests.

Sys.setenv("LANGUAGE" = "EN")

Last issue is the fia database that is no longer available and explain why the tests are skipped on CI for ls_list_usa() and ls_fetch_usa(). I think using {rFIA} may solve the issue with #17 and #11.

gowachin commented 1 year ago

FIA dataset is only available through SQL download and {DBI} usage. This takes way longer to download and we don't need all of the data provided.

Function from {rFIA} return error 404 as the website does from CSV and and zip files. (issue here)

gowachin commented 1 year ago

Merge should come soon