search

kunstmusik / blue

Blue - An Integrated Music Environment
https://blue.kunstmusik.com
GNU General Public License v2.0
130 stars 11 forks source link

macOS strange behaviour with Score Objects #758

Closed boonier closed 10 months ago

boonier commented 10 months ago

Observed v2.9.0 on M1 Mac Monterey.

I'm getting some odd behaviour like grouping of score objects, and occasionally one duplicating on top another:

https://github.com/kunstmusik/blue/assets/6206789/1d91fef2-3ea0-485b-ae8c-53cca8ca07a3

I'm not sure, but I wasn't aware there was a feature to group adjacent sound objects...unless there is?

thanks

kunstmusik commented 10 months ago

This definitely looks like a bug, could you send a .blue project file for me to test and see if I can reproduce?

boonier commented 10 months ago

Sure thing, thanks

gen fm.blue.zip

kunstmusik commented 10 months ago

I can reproduce the issue here. I think I might know why it's happening but I need to do some sleuthing through git history to verify. Will report back once I have the root cause sorted out and have a fix.

kunstmusik commented 10 months ago

@boonier I think I have a fix. The issue stems from overriding the equals() method and looks like it affected JMask, ObjectBuilder, and Tracker objects. I think the change I did was safe but am continuing to test. You can find a build here:

https://github.com/kunstmusik/blue/actions/runs/6132818214

(artfacts near the bottom of the page).

My testing here has fixed up the issue with the selection quirks with your test project. If you could give this a try and confirm the fix, I'll release a 2.9.1 hotfix release.

boonier commented 10 months ago

@kunstmusik confirmed that is working properly for me now. Thanks for looking into this!

kunstmusik commented 10 months ago

Thanks @boonier for confirming! I will put together a hotfix 2.9.1 release later today. Closing out this issue.