search

kununu / slackdump2html

This script transforms a JSON file created by slackdump (https://github.com/rusq/slackdump) to a static HTML file.
MIT License
42 stars 4 forks source link

Embedded images and uploaded files not downloaded and linked #5

Open patbaumgartner opened 1 year ago

patbaumgartner commented 1 year ago

Hi. First, I need to say that I love your addition to the slackdump.

I could not find any links to files uploaded, or images embedded in the HTML files, even though they are part of the JSON downloaded by slackdump. Would that be possible to add?

Would you also take contributions?

Best, Patrick

DerDodo commented 1 year ago

Hi Patrick, thank you for the feedback! Glad that you like it!

Under "Known issues" in the README.md you'll find that "File attachments are not supported at all." (yet). We've created a prototype for the attachments, but our goal was to be able to upload the files to OneDrive and we didn't quickly find a clean solution for referencing these files - so we took it out of the scope in favor of custom emoji support, fixing some markup, etc. The custom emojis are base64-encoded and added directly in the markup. Adding bigger images that way would make the file size and loading times explode.

Right now we're not actively developing more features, but we want to maintain it and fix bugs. You're totally welcome to add this feature and create a pull request! We'll review, test, and publish it then :)

All the best, Dodo / kununu

patbaumgartner commented 1 year ago

Hi Dodo,

I was thinking of downloading all the files locally (not One-Drive) and then embedding the images with a relative path. This might be a first step in that direction.

Best, Patrick

On Mon, Feb 6, 2023 at 1:43 PM DerDodo @.***> wrote:

Hi Patrick, thank you for the feedback! Glad that you like it!

Under "Known issues" in the README.md you'll find that "File attachments are not supported at all." (yet). We've created a prototype for the attachments, but our goal was to be able to upload the files to OneDrive and we didn't quickly find a clean solution for referencing these files - so we took it out of the scope in favor of custom emoji support, fixing some markup, etc. The custom emojis are base64-encoded and added directly in the markup. Adding bigger images that way would make the file size and loading times explode.

Right now we're not actively developing more features, but we want to maintain it and fix bugs. You're totally welcome to add this feature and create a pull request! We'll review, test, and publish it then :)

All the best, Dodo / kununu

— Reply to this email directly, view it on GitHub https://github.com/kununu/slackdump2html/issues/5#issuecomment-1419023142, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADDJ7GKRE52GF65NMRBVNTWWDWYLANCNFSM6AAAAAAUSTXFGQ . You are receiving this because you authored the thread.Message ID: @.***>

DerDodo commented 1 year ago

Yes, this is a great first step. Especially when you can then for example just upload the HTML file and the attachment folder to a file-server. If you need any support, write me at dominik.dopplinger@kununu.com :)