search

kunzmi / managedCuda

ManagedCUDA aims an easy integration of NVidia's CUDA in .net applications written in C#, Visual Basic or any other .net language.
Other
440 stars 79 forks source link

Fix rnn methods #34

Closed cbovar closed 7 years ago

cbovar commented 7 years ago

Hi, a few methods related to RNN didn't seem to have the right parameters.

The calls to those methods now succeed with those modifications (although I still don't know how to properly use cudn rnn methods see my questions to nvidia here)

kunzmi commented 7 years ago

Thanks for contributing! Sorry for the late comment, I was travelling through California and I'm at GTC right now... I'll have a look at it once I'm back home.

AeroClassics commented 7 years ago

Thanks for contributing! Sorry for the late comment, I was travelling through California and I'm at GTC right now... I'll have a look at it once I'm back home.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kunzmi/managedCuda/pull/34#issuecomment-299909599

kunzmi commented 7 years ago

I went through your PR and it actually doesn't really fix the problem: In combination with pinvoke the use of "out" instead of "ref" is not recommended as the compiler can't check that the value is actually set. If the library, for what ever reason, does not set the value correctly the variable remains without defined value. This should never happen in managed world... As for the wrong arguments: I fixed that now, at the same time I upgraded to cudnn v6. In the RNN section are some argument types where I'm not 100% sure if they are correctly ported to C#. Some of your interpretations are wrong, again I'm not sure if I did it right. Please check and don't hesitate to reopen the issue.

Cheers, Michael