search

kuper-adrian / pubg-royale

A Node.js pubg api wrapper with built-in caching
MIT License
3 stars 3 forks source link

Added telemetry #3

Closed 0c0de closed 5 years ago

0c0de commented 5 years ago

Added telemetry

kuper-adrian commented 5 years ago

While looking at and testing your changes, I realized that the amount of data returned by the pubg api at the telemetry url is huge (10mb+). Opening the url in the browser brings even Firefox to a crawl. So simply using JSON.parse() and caching the object in-memory, as I have done it with every other api response until now, won't be really feasible here. If I want to make all telemetry data available through pubg-royale I will have to come up with another solution.

Anyway, I accepted and merged your pull request. Thanks for your contribution and happy Hacktoberfest 😄