Closed medusalix closed 5 years ago
Hey cool, thanks for your time and contributions 😄 This issue was not so easy to do.
Looks like you broke some tests though. But I can't really blame you, the tests are pretty messy and not fun to write or change at all (statg was my first "bigger" javascript project and my first time doing unit tests in js 🙈). Give me some time to look at your code and let me see what I can do about the unit tests and I will come back to you sometime soon 👍
In the meantime, happy remaining Hacktoberfest 😉
Whoops, didn't notice the tests failing 😄. Happy Hacktoberfest to you too.
I fixed most of the tests by now, but there are still some pieces related to checking if the player is not registered. Those tests are not needed anymore, do you think they should be removed?
Dude, nice work 👍
Sorry for being late on your pull request, but the last PUBG update not only broke the game but also the statg bot 😅 Finally found the time to look at your changes though and they look really great. I will merge your pull request after deleting the three obsolete unit tests and updating the README to reflect the changes to the stats
and match
commands.
Let me know if you have any questions about the code 😃.
Resolves #7
Tests to fix
MatchCommandHandler
should send an error message if player is not registeredshould not send api request if player is not registeredStatsCommandHandler
should send an error error message if there is no player id for discord user in db