search

kuper-adrian / statg-bot

Discord bot that posts PUBG statistics in your discord channel
MIT License
3 stars 2 forks source link

Remove "Win Points" from match command #14

Closed kuper-adrian closed 5 years ago

kuper-adrian commented 5 years ago

Since PUBG api v6.0.0 the winPoints and winPointsDelta values of the gameModeStats property are deprecated and always contain the value 0 (see here). Because of that it's quite pointless to show them on !statg match and they should be removed.

SubashAravindan commented 5 years ago

I'd like to take this up

SubashAravindan commented 5 years ago

So I basically have to remove the values from match-cmd-handler.js and stats-cmd-handler.js alone right? Or should I remove it from match-cmd-handler.test.js too?

kuper-adrian commented 5 years ago

Yeah, the values have to be removed from the stats and match command handlers. You might break some unit tests in match-cmd-handler.test.js and stats-cmd-handler.test.js when doing so, so editing these would be nice too (but it's not necessary).

Thanks for contributing 😃

SubashAravindan commented 5 years ago

I'm completely new to open source. So yeah, I'm done with the changes and what should I do now? Should I fork it? Or directly push to a new branch? Sorry for the noob question

kuper-adrian commented 5 years ago

No worries there are no "noob" questions. In fact I'm pretty new to open-source as well, so you're in good company :wink:

To answer your question: The general idea is to fork the repository first. You can think of a fork as a separate "copy" of the repository here on GitHub. In your own fork, you can make your changes on any branch you like (since your fork is your own repository so to speak). When your changes are done, you can go to this repository and open a pull request by clicking on the "pull request" tab and then "New pull request". There you can chose your branch from your own fork which is supposed to be "pulled" to this "main" repository. Then I can look at the changes you made and pull them into this repository.

If you still have questions, you could have a look at some tutorials about git, pull requests and contributing to open source. Feel free to ask any remaining questions here.

Good luck and happy Hacktoberfest :+1:

SubashAravindan commented 5 years ago

Huge thanks for the guidelines. I've made a pul request #16