search

kuper-adrian / statg-bot

Discord bot that posts PUBG statistics in your discord channel
MIT License
3 stars 2 forks source link

conclusion statistics for the last matches #5

Closed trololo151 closed 5 years ago

trololo151 commented 6 years ago

Hi, I have a great idea, you can print statistics for the last 10, 20, 30, 50 matches, maybe you know how to do it?

I also added to your bot the ability to add cd and damage depending on the level of the player's game. Shall I share with you?

trololo151 commented 6 years ago

and even this bot would be ideal if it were not necessary to register with it. And immediately take the player's nickname from the nick of the discard and then take the statistics based on the user's name

kuper-adrian commented 5 years ago

Hi, I have a great idea, you can print statistics for the last 10, 20, 30, 50 matches, maybe you know how to do it?

The official PUBG api only provides stats for any given season or a single match. So calculating the stats for the last x matches would require x api calls for every single match. The default api key you can get at https://developer.pubg.com/ is limited to 10 api calls per minute. Therefore trying to get the stats for the last x matches would exceed that limit pretty much instantly, and I don't think that it's possible without ...

  1. ...saving necessary data per player in the statg database to reduce api calls, and...
  2. ...requesting an api key that is allowed to make many more api calls (as described in the docs here).

I also added to your bot the ability to add cd and damage depending on the level of the player's game. Shall I share with you?

Contributions are always welcome and I would love to see the features you have added. Best way to share your changes would be to fork this repository, make your changes there and then create a pull request. Detailed steps and help can be found here and here.

and even this bot would be ideal if it were not necessary to register with it. And immediately take the player's nickname from the nick of the discard and then take the statistics based on the user's name

That's actually a cool idea and I will look into implementing it.

kuper-adrian commented 5 years ago

As I was not able to find the time to implement your feature request (stats without register) yet, I opened a seperate issue (#7) and marked it with the hacktoberfest label. Maybe someone else will be able to get to it before I can.