search

kuper-adrian / statg-bot

Discord bot that posts PUBG statistics in your discord channel
MIT License
3 stars 2 forks source link

Wrong rank/win place when using "!statg match" #9

Closed kuper-adrian closed 5 years ago

kuper-adrian commented 5 years ago

The win place of individual players inside the same squad can differ (e.g. when a player dies and his team lives on). Since the bot uses the win place of the first player in the squad on !statg match, this leads to misleading/wrongly displayed ranks.

To fix this, the win place of the entire squad should be used inside match-cmd-handler.js (check api docs here).

medusalix commented 5 years ago

The rank of the entire squad should be provided by roster.attributes.stats.rank, right? I'm not too familiar with PUBG, so I want to make sure I'm seeing this correctly before making a pull request 😃.

EDIT: Seems to be working fine, I'm going for it.

kuper-adrian commented 5 years ago

roster.attributes.stats.rank looks good.