search

kupiakos / LapisMirror

Mirrors images from various sites, and exports them to mirrors like imgur. Plugin-based.
MIT License
19 stars 6 forks source link

Feature Request: Link to Blog picture came from #41

Closed martinjh99 closed 7 years ago

martinjh99 commented 7 years ago

When its posting the tumblr blog/DA page (wherever it got the pic from) that it got the picture from how about making the name of the tumblr a link to said blog/DA page?

Eg:

Mirrored post from the tumblr blog "BOOM CLAP":

With BOOM CLAP being a link to dashingicecream.tumblr.com or the exact page where the pic was from up to you...

Shugabuga commented 7 years ago

I don't this would be too difficult to implement (in fact, some newer plugins like the Derpibooru and FA ones do this IIRC).

I would propose a reply like this:

Mirrored post from the tumblr blog "BOOM CLAP":

...with the post link being the exact page where the picture was, and BOOM CLAP being the author's main page / Tumblr blog home.

Idk if I have time to implement this, but I may get around to it eventually.

martinjh99 commented 7 years ago

No worries mate :) If I could program in Python might have given it a go myself!

Shugabuga commented 7 years ago

Yeah, holidays and other projects is making it hard to find time to code it and (most importantly) test it.

spiral6 commented 7 years ago

I'll give it a shot on working on it, will also add it to VelvetBot's functionality.

spiral6 commented 7 years ago

@Shugabuga Additionally, is there a subreddit I should create or work with to test functionality of the bots?

Shugabuga commented 7 years ago

/r/HeyItsShugaTest (my test subreddit) or /r/BotTest (for any bot) are both fine if you want to test it. My subreddit already is full of TheMirrorPool test posts. Also, if you PR the feature, I'll add it to TheMirrorPool (I try to keep it updated).

spiral6 commented 7 years ago

42

kupiakos commented 7 years ago

Does this handle reblogs properly? For example, if user A posts picture B, and user C reblogs picture B, which then has the reblogged link posted on Reddit, will the link in the mirror comment go to User A's or User B's blog? If it just posts what the original Reddit link was, I see no reason to put it in the comment.

spiral6 commented 7 years ago

Not sure, although if it does post only the reblog, it should just be a quick fix by using tumblr's API or scraping to figure out where the original is from. Then I can post the original link in the comment. I'll test it soon.

spiral6 commented 7 years ago

Alright, updated pull request that now determines reblog information, if it exists, and now posts the original author URL to post, blog, and name of blog.

Shugabuga commented 7 years ago

Neat!

spiral6 commented 7 years ago

Tumblr merged, now to work on the DeviantArt plugin.

spiral6 commented 7 years ago

Works according to test. Should be able to close this issue once this is merged.