Closed kupiqu closed 4 years ago
Tentative fix has been pushed 7c4c6b56cffc37b95e52f0932d13a02f95266aff
Will keep this open a little bit to see if users give some feedback...
EDIT: I reverted the change as it does not work consistently. Still looking for a proper fix...
@trmdi @psifidotos sorry to ping you, but I would highly appreciate some help on this.
If you are actively using SBE and see these glitches, could you please tell?
I made a video so you know what I talk about:
I have no clue what is causing this, so any hint would be more than appreciated!
the last days I am also noticing it, even with Breeze decoration but I dont what is its cause... There is chance that this KWin bug but I am not sure...
the last days I am also noticing it, even with Breeze decoration but I dont what is its cause... There is chance that this KWin bug but I am not sure...
Mmm, I see. That would be a relief from my side certainly, but I wonder now if these glitches still come from SBE and somehow migrate to other Breeze themes. For instance, if one uses the option Maximized Windows
in Hide window title bar
that is conveyed to the Breeze theme, which does not have such an option and removes the title bar in all conditions.
For the purpose of this glitch issue here, I'd like to know if the glitches are still present if SBE is uninstalled from the system. I would do it myself, but so far I failed to see the glitches in Breeze and Breeze Enhanced.
If you recall what you changed in Breeze when you saw the glitch, I could try to reproduce it myself.
the last days I am also noticing it, even with Breeze decoration but I dont what is its cause... There is chance that this KWin bug but I am not sure...
And thank you very much for your response, btw!
I also have the glitches with SBE. Selecting SBE causes glitches and if you select another decoration after that, glitches are still present until you restart the system, then everything goes back to normal for other decorations. My system: Operating System: openSUSE Tumbleweed 20191128 KDE Plasma Version: 5.17.3 KDE Frameworks Version: 5.64.0 Qt Version: 5.13.1 Kernel Version: 5.3.12-1-default
Note: I use Kwin Low Latency if that has any effect I'm not sure
glitches are still present until you restart the system
Please execute kwin --replace
in krunner instead as a workaround for now, you don't need to restart.
You can use kwin_x11 --replace
or kwin_wayland --replace
if kwin is not available in your system.
I am almost convinced that the issue is in SBE and I think it is related to the options of shadows for inactive windows.
The issue was first triggered in commit 9673c5e1f1b7e0aeb7e1655bb6840e03fe6614ba but this one came from a minor bug that was fixed afterwards.
However, I didn't find the way to fix the issue once further options were introduced in commit 86f1f3f7bf5b90beb671e3d0e3865b31eb7524ab.
I wasted so much time and ran out of ideas, so I would highly appreciate if anyone else would help on this.
@kupiku
Could you write steps to reproduce it? Sometimes I change SBE settings but have not seen the problem like your video.
@trmdi, thanks for willing to help on this!
Unfortunately it is something that is not 100% reproducible, but I found out that trying to change shadow features, especially in inactive windows, usually trigger this. And playing with shadow colors and inactive shadow settings are the ones that more frequently do so.
So:
Let me know if you can reproduce...
Can't reproduce it. Maybe it relates to the video driver like the button glitch issue ?
Does it help if you add an update()
here: https://github.com/kupiqu/SierraBreezeEnhanced/blob/51b9d9914500bf1b707b404c9bb565e1fc53f652/breezedecoration.cpp#L685 ?
Can't reproduce it. Maybe it relates to the video driver like the button glitch issue ?
maybe, but curiously this is a different newer computer that doesn't suffer the button glitch
Does it help if you add an
update()
here:?
I have a busy day today, but will try to restore this asap
Does it help if you add an
update()
here: https://github.com/kupiqu/SierraBreezeEnhanced/blob/51b9d9914500bf1b707b404c9bb565e1fc53f652/breezedecoration.cpp#L685?
I have a busy day today, but will try to restore this asap
I think this was not here before. I mean you to try adding it. :D
Yes sorry, this was actually a response to #62
Regarding update(), I think I tried all these combinations, but will do again for the case it is any different to what I did previously
I have a similar issue. Sometimes the button surrounding become translucent and you can see the background. Clicking outside makes it go way. It only happen on hovering.
That's a different issue. Please see https://bugs.kde.org/show_bug.cgi?id=397215
You may want to try these workarounds:
That was a fast reply. Thanks. Yes my issue is exactly what you linked. I'll try these.
Can confirm I'm experiencing this issue as well. First noticed it when I enabled window borders, which caused window decorations to disappear completely. Both breeze and SBE were completely blank. This also disabled shapecorners, so all my window corners were square. Fixed it by restoring SBE settings to default, for the most part anyway. Default breeze theme is still corrupted.
Edit: now if I disable shadows within SBE, corners become square again. There's definitely something funky going on here
as a workaround, try using https://github.com/kupiqu/SierraBreezeEnhanced/issues/47#issuecomment-560357194
using export MESA_LOADER_DRIVER_OVERRIDE=iris (intel igpu) as an environment variable fixes this for me.
using export MESA_LOADER_DRIVER_OVERRIDE=iris (intel igpu) as an environment variable fixes this for me.
Thanks, I'm running very busy at the moment, but I will give it a try when I have a chance.
Somehow the changes introduced in the decorations for Plasma 5.18 made this issue (almost) disappear. Now I only note a mild, transient glitch in kwin when a new window is open, but no permanent issue with the decorations.
I think this may indeed be related to upstream issues with the graphics driver and kwin. So I'll close this issue. If I see further problems or somebody still sees them, I may reopen the issue.
I realized that in my system using opengl 2.0 fixes the issue. If I use 3.1 the issue comes back.
I realized that in my system using opengl 2.0 fixes the issue. If I use 3.1 the issue comes back.
Using latest mesa fixes it. It works fine even on opengl 3.1
Cool, but I think I also use the latest. What mesa version do you use? Mine is 19.2.8-0ubuntu0~18.04.3
I'm using mesa git version.
I'm using mesa git version.
Great, looking forward for next release!
When I modify settings and borders, I need to restart kwin to avoid weird glitches.
I don't know where this comes from but would appreciate any hint from the community to know how to fix this