search

kurator-dev / kurator

Unified resource orchestration, unified scheduling, unified traffic management and unified telemetry for distributed cloud
https://kurator.dev
Apache License 2.0
242 stars 39 forks source link

Fix: Update Makefile for Unlink error #662

Closed Flying-Tom closed 2 months ago

Flying-Tom commented 2 months ago

What type of PR is this?

/kind bug

What this PR does / why we need it:

PACKAGE_SHIM in Makefile is a directory and .INTERMEDIATE rm cannot handle it.

ref: kyverno/Makefile

Which issue(s) this PR fixes: Fixes #661

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
netlify[bot] commented 2 months ago

Deploy Preview for kurator-dev canceled.

Name Link
Latest commit e96975bb375dec157982e0acf6350d6dc62792d0
Latest deploy log https://app.netlify.com/sites/kurator-dev/deploys/66afa8f71d61f90008d60bd2
LiZhenCheng9527 commented 2 months ago

/lgtm

kurator-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kurator-dev/kurator/blob/main/OWNERS)~~ [hzxuzhonghu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment