Closed joelalejandro closed 3 years ago
@spersico For some reason CI is not passing, apparently there's a deep dependency package conflict, related to Node versions:
Can you take a look?
Fixed, had to update a CI action.
@spersico This is good to go!
After three long months of delaying work on upgrading dependencies, I finally got around to the problems @spersico found in #271.
Older versions of Knex didn't support (or probably, it did support it but we didn't notice) fully async transaction creation. Thus, we wrapped
knex.transaction()
in a promise to auto-resolve it, making it compatible with async/await.With the current version, documentation reports that we can directly use:
Using
trace-unhandled
with thedummy-app
, I discovered we had a number ofUnhandledPromiseRejection
errors on every call:This particular piece of the stack trace got me in the right direction:
So, this is it. The PR that fixes all things (TM).