search

kurkle / chartjs-chart-sankey

Chart.js module for creating sankey diagrams
MIT License
152 stars 29 forks source link

Fix maxY calculation when all nodes are at top #33

Closed nassissme closed 3 years ago

nassissme commented 3 years ago

Hi !

I found a bug when you have all the nodes on the same y. The labels are not displayed anymore because of a bad calculation of the maxY.

Example : https://codesandbox.io/s/error-labels-xjc3o

Here is a proposal for a fix with a test.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

kurkle commented 3 years ago

Thanks @nassissme