search

kurkle / chartjs-chart-treemap

Chart.js module for creating treemap charts
MIT License
137 stars 34 forks source link

Move all drawings (captions, labels and dividers) in the element drawing #102

Closed stockiNail closed 2 years ago

stockiNail commented 2 years ago

This PR is moving all drawings in the element drawing because part of it, improving fallbacks of element options.

kurkle commented 2 years ago

Needs a rebase

stockiNail commented 2 years ago

rebased

stockiNail commented 2 years ago

@kurkle about sonar issue, what about https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/#improvements-for-public-repository-forks ? It seems it should solve the issue about sonar cloud and the usage of the secrets from external PR.