search

kurkle / chartjs-chart-treemap

Chart.js module for creating treemap charts
MIT License
140 stars 34 forks source link

Add sample using Datalabels plugin #107

Closed stockiNail closed 2 years ago

stockiNail commented 2 years ago

Fix #75

EDIT: sets karma-rollup-preprocessor to version 7.0.7 to avoid usual bugs on that.

stockiNail commented 2 years ago

@kurkle tought: due to the datalabels plugin sounds working with treemap controller, do you think it still makes sense to have labels and captions capabilities in the controller? Maybe they could be delegated to data-labels.

kurkle commented 2 years ago

@stockiNail about dataLabels, yes it would be best to rely on that plugin for the labels, it would avoid a lot of code.

stockiNail commented 2 years ago

@stockiNail about dataLabels, yes it would be best to rely on that plugin for the labels, it would avoid a lot of code.

I thought more on that. for Labels could be a good idea even if we couldn't address some enhancement (see #92). The caption could be manage by datalabels because needs to add space for that to the element and we need options that, going to datalabels, could be managed only by plugin. Therefore some login on labels for caption will remain.