search

kurkle / chartjs-plugin-gradient

Easy gradients for Chart.js
MIT License
33 stars 6 forks source link

Remove imported CHART.JS parts from distribution file #18

Closed stockiNail closed 2 years ago

stockiNail commented 2 years ago

Fix #17

This PR excludes the CHART.JS parts from distribution file of the plugin. It removes also the direct dependency from @kurkle/color, leveraging on what it's included in CHART.JS.

stockiNail commented 2 years ago

@kurkle not clear how to exclude @kurkle/color. Whatever import I set sounds wrong. :( Maybe it's not possible.

kurkle commented 2 years ago

I think importing color from 'chart.js/helpers' should work, but I guess you already tried that?

stockiNail commented 2 years ago

I think importing color from 'chart.js/helpers' should work, but I guess you already tried that?

No I didn't but it works!!! ur awesome!

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

kurkle commented 2 years ago

I think importing color from 'chart.js/helpers' should work, but I guess you already tried that?

No I didn't but it works!!! ur awesome!

Only doubt is if it works with chart.js v2, I don't remember if it has a compatible export.

stockiNail commented 2 years ago

Only doubt is if it works with chart.js v2, I don't remember if it has a compatible export.

Ok, I'll test it against version 2.9.4 before releasing the PR

stockiNail commented 2 years ago

It sounds working with 2.9.4 but the issue is not the color part but in version2, the scale object doesn't have parse method.

With #16, the support of CHART.JS 2.x was dropped....

kurkle commented 2 years ago

It sounds working with 2.9.4 but the issue is not the color part but in version2, the scale object doesn't have parse method.

With #16, the support of CHART.JS 2.x was dropped....

Right, that one should be fixed then. Chart.version is a good checkpoint for v3, in case you want to do it :)

stockiNail commented 2 years ago

absolutely yes! I'll do in this PR, ok? or do you prefer another one? For me it's the same

stockiNail commented 2 years ago

Created another PR #19 for fixing

stockiNail commented 2 years ago

I have created additional workload to you.... sorry, thank you for everything!

kurkle commented 2 years ago

I have created additional workload to you.... sorry, thank you for everything!

You also fixed some major issues with this plugin, so thank you! :) I'm going to push these changes as v0.3.0, and do the docs & samples later when I have the time.

kurkle commented 2 years ago

(would have done this right away, but actions are down again, so will check back later)

stockiNail commented 2 years ago

Ok, no hurry, As said, I can go ahead using my local dist file I have to develop some java classes, test them, create doc and so on therefore I need some days. Furthermore we have planned to go to next version in 1 month (otherwise now too close to the previous one)