Add test cases for all axes types

stockiNail commented 2 years ago

This PR is:

adding test cases for all axes types
adding chartjs-adapter-luxon and luxon dependencies (enabling tests on time axes)
adding test-lint mpn command in order to add the lint test invoking npm test

stockiNail commented 2 years ago

CI fails because "Set the SONAR_TOKEN env variable.". I don't see where you remove Windows test. Maybe I could change GHA ci file.

Furthermore I removed (temporarily) the test on time axes because CI failed (even if locally it works).

kurkle commented 2 years ago

Try to rebase to latest master, should help.

kurkle commented 2 years ago

hmm, no, its about pr from forked repo. I'll need to investigate a bit more.

stockiNail commented 2 years ago

hmm, no, its about pr from forked repo. I'll need to investigate a bit more

yes because I didn't find anything new to merge.

stockiNail commented 2 years ago

Furthermore I removed (temporarily) the test on time axes because CI failed (even if locally it works).

I think have found the reason... could be the "locale"

kurkle commented 2 years ago

This is the reason SONAR_TOKEN is not set:

Note: With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.

stockiNail commented 2 years ago

Note: With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.

Ok... that means the workflow will always fail, I guess.

kurkle commented 2 years ago

Note: With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.

Ok... that means the workflow will always fail, I guess.

I updated the CI again to only run sonar if the token exists

stockiNail commented 2 years ago

I updated the CI again to only run sonar if the token exists

Shall I rebase, I guess?

kurkle commented 2 years ago

Don't try to fix the duplication in tests :)

stockiNail commented 2 years ago

Don't try to fix the duplication in tests :)

Already done... changed the exclusion in the sonar.properties (the paths must be comma separated but without blanks)

kurkle commented 2 years ago

The exclusions only apply when analysis is run from CI. This sonarcloud bot analysis only uses the settings I provided from sonarcloud UI (and it was missing the exclusions). I'm not sure if the spaces are needed for the CI.

stockiNail commented 2 years ago

This sonarcloud bot analysis only uses the settings I provided from sonarcloud UI (and it was missing the exclusions). I'm not sure if the spaces are needed for the CI.

Anyway ok for me! Tomorrow (if I can, or at least on Monday) I will have a look to Sonar coverage because it's not clear to me what I have seen.

stockiNail commented 2 years ago

And I need to understand why the tests on time don't work, even if I used the dates in the data as strings. But I can submit another PR for those tests

kurkle commented 2 years ago

can you rebase once more? I'd like to see if I can get the coverage reported here :)

stockiNail commented 2 years ago