search

kurkle / chartjs-plugin-gradient

Easy gradients for Chart.js
MIT License
37 stars 6 forks source link

Add colors node consistency check #27

Closed stockiNail closed 2 years ago

stockiNail commented 2 years ago

This PR is adding check on colors node consistency to avoid exception

kurkle commented 2 years ago

I believe the check is not just because it was used, but because the chart can be rendered non-visible initially and have invalid area in that case. I'm not sure about this, but I think there is no harm in keeping the check.

The colors check seems good to add.

stockiNail commented 2 years ago

I believe the check is not just because it was used, but because the chart can be rendered non-visible initially and have invalid area in that case. I'm not sure about this, but I think there is no harm in keeping the check.

OK! I have never done in my plugins therefore I should evaluate also in my plugins. I'll put it again.