search

kurkle / chartjs-plugin-gradient

Easy gradients for Chart.js
MIT License
37 stars 6 forks source link

Add type definition #32

Closed deen13 closed 2 years ago

deen13 commented 2 years ago

This pull requests adds a typescript definition. I couldn't manage to pass the tests locally. It seems like they're flaky at least on my machine.

kurkle commented 2 years ago

Where did your local tests fail?

deen13 commented 2 years ago

I ran the test three times and got three different failing tests on firefox.

Run 1

Firefox 99.0 (Ubuntu 0.0.0) Gradient plugin auto /base/test/fixtures/rRadialLinearAndLegendDataIndexReverse.js FAILED

Run 2

Firefox 99.0 (Ubuntu 0.0.0) Gradient plugin auto /base/test/fixtures/rRadialLinearReverse.js FAILED

Run 3

Firefox 99.0 (Ubuntu 0.0.0) Gradient plugin auto /base/test/fixtures/xCartesianTimeParsingOnColors.js FAILED