search

kurkle / chartjs-plugin-gradient

Easy gradients for Chart.js
MIT License
33 stars 6 forks source link

Use scale area to create the gradient instead of chart area #9

Closed stockiNail closed 2 years ago

stockiNail commented 2 years ago

Fix #8

This PR uses scale area, instead chart one, to create the size of the gradient

stockiNail commented 2 years ago

@kurkle I didn't find any check if the scale instance is consistent, after getScale. Maybe could it be added?

kurkle commented 2 years ago

@kurkle I didn't find any check if the scale instance is consistent, after getScale. Maybe could it be added?

No objections, currenlty it fails with:

Uncaught TypeError: Cannot read properties of undefined (reading 'getPixelForValue')

stockiNail commented 2 years ago

No objections, currenlty it fails with:

Let me add it in next minutes

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication