search

kurko / ember-indexeddb-adapter

Ember Data IndexedDB Adapter
MIT License
43 stars 16 forks source link

Use configured relationship names #20

Closed rsutphin closed 8 years ago

rsutphin commented 10 years ago

The convention for relationship names is to use the plural version of the name of the model they contain. But ember-data does not require this and neither should this adapter. E.g., as in the test that's included in this PR, you might have a StreetAddress model that is used for separate home and work address relationships for a person.

kurko commented 10 years ago

Right. Makes sense. I'll run the tests locally tomorrow and merge.

kurko commented 10 years ago

Can't merge, as it needs to be rebased :(

rsutphin commented 9 years ago

Rebased.

rsutphin commented 9 years ago

@kurko, is there anything I can do to get this merged soon? I'm working on another fix in the same area of the code and it would be great to not have to deal with merge conflicts when I submit that one.

kurko commented 8 years ago

I'm really sorry for this. Somehow I never saw this notification and ended up never looking at this. I'm really, really sorry for ignoring this PR.