search

kurko / ember-json-api

JSON API adapter for Ember Data.
MIT License
254 stars 62 forks source link

Null links are not handled properly #54

Closed wagenet closed 9 years ago

wagenet commented 9 years ago

https://github.com/kurko/ember-json-api/blob/899825dd63354c6f5305879ddd5ee7403685fbb8/src/json-api-serializer.js#L47 - If linkValue is null it will pass the typeof 'object' test. Should just add linkValue && to the start of that conditional.

I will try to PR soon.

csantero commented 9 years ago

51 addresses this. @kurko has been pretty busy lately so he hasn't had time to merge it.

wagenet commented 9 years ago

@csantero Ah, thanks :) I skimmed the issues but missed that.