search

kurko / ember-json-api

JSON API adapter for Ember Data.
MIT License
254 stars 62 forks source link

[Upgrade] Upgraded to ember-data beta.19 and ember v1.12.0 #80

Closed Asgaroth closed 9 years ago

wvteijlingen commented 9 years ago

:+1: would be great if this could be merged in!

SeyZ commented 9 years ago

:+1: Needed

kurko commented 9 years ago

This is awesome @Asgaroth, but needs to be rebased :D

Asgaroth commented 9 years ago

Will work on this tonight.

On Tue, Jun 2, 2015 at 9:38 AM, Alexandre de Oliveira notifications@github.com wrote:

This is awesome @Asgaroth, but needs to be rebased :D

Reply to this email directly or view it on GitHub: https://github.com/kurko/ember-json-api/pull/80#issuecomment-107975829

Asgaroth commented 9 years ago

Upgraded to ember-data beta.19 and ember v1.12.0

cc: @wvteijlingen @SeyZ @kurko

kurko commented 9 years ago

Could you just update the README replacing 16.1 with 19? Other than that, it looks very good.

SeyZ commented 9 years ago

Awesome work @Asgaroth

wvteijlingen commented 9 years ago

Nice work, tnx! :+1:

GlennGeelen commented 9 years ago

Looks awesome although when I use this PR in my project I get deprecations on type.typeKey in the json-api-adaptor.js this should be type.modelName. I was that @Asgaroth already fixed this in the master branch of his fork so I was wandering if you could add this in the beta18 branch as well.

kurko commented 9 years ago

@GlennGeelen I don't quite understand your comment. It was changed to modelName, so you shouldn't be seeing typeKey deprecations anymore.

Merging this and if there's anything pending, we can open a new PR.