search

kurko / ember-json-api

JSON API adapter for Ember Data.
MIT License
254 stars 62 forks source link

Upgrading to JSON API 1.0 #88

Closed eneuhauser closed 9 years ago

eneuhauser commented 9 years ago

This merges PR #14 from @barelyknown upgrading to JSON API 1.0, includes the updates from @Asgaroth upgrading ember-data, as well as some minor tweaks. I've run this within my own application and do not see any issues.

jonkoops commented 9 years ago

Nice work @eneuhauser and @barelyknown! I will probably be spending next week migrating some of our Ember apps over to JSON API v1.0. I'll make sure to use this and give it a test.

kurko commented 9 years ago

This a very good PR! Please test @jonkoops and let us know :smile:

jonkoops commented 9 years ago

I've had some time to test today, unfortunately the library we're using to create our responses has a blocking bug that needs to be resolved before I can do a complete test of our app (loading associated records are broken in it).

The pull request seems sound and I have had the ability to test parts of it since our backend is only half broken. The data seems to be coming trough fine from what I can see. Since @eneuhauser has also been running this on his application I think we can go ahead and merge this so we can move forwards on our deprecation path.

jonkoops commented 9 years ago

The pull request is good and all the tests seem to be running fine and dandy. I am going ahead an merge this. Thanks again to @eneuhauser and @barelyknown for your awesome work.

shicholas commented 9 years ago

I've been following this project for a while and thanks so much to you all (developers and maintainers)!

barelyknown commented 9 years ago

:+1: My pleasure!

kurko commented 9 years ago

Released 0.6.0 with this.