search

kurokirasama / nushell_sublime_syntax

Nushell syntax highlight for sublime text
MIT License
12 stars 3 forks source link

fix: LSP settings naming error #6

Closed brian6932 closed 2 months ago

brian6932 commented 2 months ago
  1. Fixed the unmatched json braces.
  2. Renamed file with an Example- prefix to avoid a plugin error on startup

    Realistically if an actual LSP-*.sublime-settings file were to be included.

  3. command wouldn't be a hardcoded path, and instead the user's PATH env should be checked in a plugin.py file, with potentially an option to hardcode.
  4. Platform would be checked with the os module to resolve bin filename differences (Windows .exe suffix).

Imo, such a feature should be apart of it's own plugin, as typically LSP packages are separated in this way.