kuroni / bongocat-osu

An osu! Bongo Cat overlay
MIT License
2.15k stars 311 forks source link

Small change(image re-order/arrangement) #85

Open orloko opened 4 years ago

orloko commented 4 years ago

1st just want to say that I'm really happy to get to know this software, I've seen osu before(but not much) never played or follow the community, by accident I check a friend of mine playing/streaming and he had it setup (bongocat)...I was simple amazed, blown away...(recently I lend my webcam to my sister and this will be PERFECT for me...) sorry if here isn't the right place to comment that. 🤭

anyway....I notice a small thing that could be changed, but not on the config.json(i think) if you re-arrange the Smoke.png placement(on the main code) before "anything else", any custom image (or even the up.png/wave.png) would be on top of that specific region, making the glasses appears behind the hand 💯

With the mouse support coming soon on Custom it would be great to have a "new string" for the face images placement, that way any custom image set on that "string" (on the config.json for example) would be on top of the "background/base image" but before anything else so to speak...

great work...loving...

kuroni commented 4 years ago

It is actually in the newest code I think. Mouse is already on custom mode, I just need some polish before publishing.

orloko commented 4 years ago

also, I notice that if you hold the key1(while you are holding it) press the key2(click and release) the image it's going to change from "image1" to "image2" but will stay on "image2" even tho you're not using it anymore (the image/function does not goes back to image1(because it only recognizes key press)) is there any way that could be adjusted on the config.json to recognize the key input while holding it instead of just key press ?

kuroni commented 4 years ago

Oh that's a bug. Thanks for pointing that out.

Sorry for the late reply I was too busy :(