kurotu / tiny_vcc

Yet Another VRChat Creator Companion (VCC) for Mac and Windows
GNU General Public License v3.0
26 stars 2 forks source link

Bugs: Unity installation is not done normally. #5

Closed waya0125 closed 8 months ago

waya0125 commented 9 months ago

Describe the bug Install is not running properly

To Reproduce Press the install button, that's all.

Expected behavior Probably, but the type of CPU is being asked at the time of installation, so I think it would be good to solve it.

Screenshots It is japanese text. I'm so sorry.

Screenshot 2023-10-07 10 11 13

Desktop (please complete the following information):

kurotu commented 9 months ago

I believe 916d5a65 should fix the issue, but I don't have apple silicon mac. Would you try this artifact of the workflow job?: https://github.com/kurotu/tiny_vcc/actions/runs/6439011224

waya0125 commented 9 months ago

Got it. I'll check it.

waya0125 commented 9 months ago

Sorry, but I don't know how to initialize the application settings in a Mac environment. Once Install is done, I need to blow up the settings, but it seems that just erasing the package is not enough. Do you know anything about this?

kurotu commented 9 months ago

Sorry for inconvenience, you need to remove existing Unity Editor and reset VCC settings.

  1. Quit Tiny VCC.
  2. Remove Unity folder: /Applications/Unity/Hub/Editor/2019.4.31f1
  3. Edit VCC settings: ~/.local/share/VRChatCreatorCompanion/settings.json
    /// Clear pathToUnityExe and unityEditors values. Keep other parameters as is.
    {
      "pathToUnityExe": "",
      "unityEditors": []
    }
kurotu commented 9 months ago

Please let me know if it seems hard to test. I'll release the bugfix as is.

waya0125 commented 9 months ago

image image It's probably not working correctly. It's stopped in the same place as last time.

kurotu commented 9 months ago

Sorry again, I forgot to let you know. Please make sure you are using Unity Hub 3.5.1 or later.

waya0125 commented 9 months ago

I using Unity Hub 3.5.2 image

kurotu commented 9 months ago

Thank you for kind feedback. I'll investigate more.

waya0125 commented 9 months ago

Thanks you.

When I looked it up, I was glaring that this might be the cause because there is a warning message at the beginning that occurs when updating to macOS Sonoma.

kurotu commented 9 months ago

I made a new artifact: https://github.com/kurotu/tiny_vcc/suites/17068682673/artifacts/974918616 The problem was architecture detection in tiny vcc's code.

"Secure coding" sentence seems just a warning for Unity Hub on Sonoma. I think it's not related to this issue.

waya0125 commented 9 months ago

Ok. I'll check it out now. Sorry for the irrelevant remarks.

waya0125 commented 9 months ago

OK, working. image

waya0125 commented 9 months ago

Ahhhh, I was able to install it, but I can't recognize the installed file and it will be an error judgment. image

kurotu commented 9 months ago

Unity Hub CLI's output is different on Apple Silicon, so version detection failed. Sorry to bother you again, I made a new artifact to fix: https://github.com/kurotu/tiny_vcc/suites/17112075644/artifacts/977497951

I believe this is the last one because Unity Hub part is all done.

waya0125 commented 9 months ago

I can now get information from Unity Hub correctly, but it can be written even if it is not Unity 2019.4.31f1, is it okay? image

kurotu commented 9 months ago

Thank you for testing. At least now we can get unity installed, so I can inspect further behavior on my Mac. Would you execute Unity Hub in terminal? I'll check it with #4.

/Applications/Unity\ Hub.app/Contents/MacOS/Unity\ Hub -- --headless editors --installed
waya0125 commented 9 months ago

I was late in confirming. My apologies. I'll try to run it right after this.

waya0125 commented 9 months ago

image

waya0125 commented 9 months ago

Unity that comes at the top is automatically assigned, so if 2019 is not included, the installation should be executed, but it is no longer executed.

kurotu commented 8 months ago

I added version check for the issue above. But it originally relies on vpm check unity, so the issue may happen. In such case, please manually install appropriate unity.

waya0125 commented 8 months ago

When I specified it by hand, it started to work. I'm sorry to trouble you for a long time.

kurotu commented 8 months ago

v0.6.0 should fix the issue. Thank you for kind cooperation.