Deprecation Warning With Latest Version.

kursjan / petitparser2

A high-performance top-down parser

MIT License

41 stars 19 forks source link

Deprecation Warning With Latest Version. #22

Closed deech closed 6 years ago

deech commented 6 years ago

With the latest version of PetitParser2Gui in Pharo 6.1 whenever I click on a node in the Graph tab I get the following warning:

The method Object>>#name called from PP2ParserBrowser>>#compose has been deprecated.
Implement your own domain representation of an object, or use #asString or #printString instead.

Select Proceed to continue, or close this window to cancel the operation.

kursjan commented 6 years ago

Thanks for reporting this, I will fix as soon as possible...

Or, of course, relevant pull requests are also welcome,...

kursjan commented 6 years ago

Hi deech. I tried to reproduce, but I failed :(

As far as I see, all PP2Node classes override the name selector. And the PP2ParserBrowser is supposed to call name on those. But it Is it possible that one of your parsers does not return PP2Node?

Could you please share which object causes the mentioned warning?

JurajKubelka commented 6 years ago

hi @deech: I cannot reproduce it neither.

kursjan commented 6 years ago

Closing as obsolete. Please let me know if it is somehow reproducible.