Compile errors with a temp variable that overlap an instance variable:
result in PP2CompositeNodeExamples>>parse:production:to:end:checkResult:
context in PP2OptimizationParserTest>>testCache2
References to ByteString would be created if you simply used String or if something were added to Grease:
PP2BufferStream->copyFrom:to:
PP2BufferStream->initializeForSize:
It would be nice if UI-related references were in a separate package:
FormCanvas is referenced from PP2EventsTrace->eventsMorph:
GLMWrapper is referenced from PP2DebugResultIntegrationTest->testGtCacheReport
Morph is referenced from PP2DebugResult->asEventsMorph
It would be nice if there were an alternative to thisContext
PP2RecordingContext>>node
PP2RecordingContext>>strategy
PositionableStream>>asPetit2Stream references collection. Could you instead reference self contents?
Several methods ( PP2InMemoryContext->'adoptString:', PP2InMemoryContext->'next:', PP2InMemoryContext->'nextFor:', PP2InMemoryContext->'readLimit', PP2InMemoryContext->'stream:', PP2InMemoryContext->'upTo:', PP2RecordingContext->'stream:') reference readLimit that doesn't exist in GemStone. Would there be another way to test this using message sends?
GemStone doesn't have SubscriptOutOfBounds (see PP2BufferStreamTest->'testCopyFromToOOB', PP2BufferStreamTest->'testRandomAccessTooMuchBacktrack', PP2BufferStreamIntegrationTest->'testIdentifierSmallBufferError', PP2BufferStreamIntegrationTest->'testStreamBacktrackBufferTooSmall', PP2BufferStreamIntegrationTest->'testStreamBufferTooSmall', PP2BufferStream->'atPosition:', PP2BufferStream->'copyFrom:to:'). If the tests are looking only for the signals in PP2BufferStream, could you make your own subclass of Error?
Compile errors with a temp variable that overlap an instance variable:
result
inPP2CompositeNodeExamples>>parse:production:to:end:checkResult:
context
inPP2OptimizationParserTest>>testCache2
References to
ByteString
would be created if you simply usedString
or if something were added to Grease:PP2BufferStream->copyFrom:to:
PP2BufferStream->initializeForSize:
It would be nice if UI-related references were in a separate package:
FormCanvas
is referenced fromPP2EventsTrace->eventsMorph:
GLMWrapper
is referenced fromPP2DebugResultIntegrationTest->testGtCacheReport
Morph
is referenced fromPP2DebugResult->asEventsMorph
It would be nice if there were an alternative to
thisContext
PP2RecordingContext>>node
PP2RecordingContext>>strategy
PositionableStream>>asPetit2Stream
referencescollection
. Could you instead referenceself contents
?Several methods
( PP2InMemoryContext->'adoptString:', PP2InMemoryContext->'next:', PP2InMemoryContext->'nextFor:', PP2InMemoryContext->'readLimit', PP2InMemoryContext->'stream:', PP2InMemoryContext->'upTo:', PP2RecordingContext->'stream:')
referencereadLimit
that doesn't exist in GemStone. Would there be another way to test this using message sends?GemStone doesn't have
SubscriptOutOfBounds
(seePP2BufferStreamTest->'testCopyFromToOOB', PP2BufferStreamTest->'testRandomAccessTooMuchBacktrack', PP2BufferStreamIntegrationTest->'testIdentifierSmallBufferError', PP2BufferStreamIntegrationTest->'testStreamBacktrackBufferTooSmall', PP2BufferStreamIntegrationTest->'testStreamBufferTooSmall', PP2BufferStream->'atPosition:', PP2BufferStream->'copyFrom:to:'
). If the tests are looking only for the signals in PP2BufferStream, could you make your own subclass of Error?Thanks!