search

kursjan / petitparser2

A high-performance top-down parser
MIT License
41 stars 19 forks source link

Do not use `ByteString` in `PP2BufferStream` #27

Closed kursjan closed 6 years ago

kursjan commented 6 years ago

For interop with GemStone, PP2 should not use ByteString string.

kursjan commented 6 years ago

@jgfoster: I suppose, it would be enough to change reference from ByteString to String. I honestly do not understand how to properly work with Streams in Pharo. Would that solution be OK for you?

What would I need to do to support WideString in infuture?

jgfoster commented 6 years ago

@kursjan: Changing ByteString to String is good for me, thanks!

As to Streams, I don't have enough experience with Pharo to give a good answer but I believe the issues relate instance variable names and whether the position is zero-based or one-based.

With regard to WideString, we'd need to investigate the overlap between Pharo's WideString and GemStone's DoubleByteString (or even Unicode16).