kurt-culley / ScrapeTrainV2

New and improved TrakTrain beat downloader.
7 stars 1 forks source link

Feature Request - Auto Tagging #1

Closed justinokay closed 6 years ago

justinokay commented 6 years ago

Hello Kurt,

Not sure if this the best place to request features. I donated few months back. Really enjoy your application. How hard would it be to tag the mp3 files with track number, title, album, artist etc?

kurt-culley commented 6 years ago

Hi Justin, glad to hear you are still using my application! I have just had a quick look and I should be able to implement MP3 ID3 tagging relatively easily. Unfortunately I am currently away in Vietnam until the 28th April, though when I get back I will have a go at adding the feature.

On Sun, 22 Apr 2018, 13:18 justinokay, notifications@github.com wrote:

Hello Kurt,

Not sure if this the best place to request features. I donated few months back. Really enjoy your application. How hard would it be to tag the mp3 files with track number, title, album, artist etc?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kurt-culley/ScrapeTrainV2/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AD4BrZH44woexOxhv5AP3zYWrnmu4hFcks5trCChgaJpZM4Tevru .

kurt-culley commented 6 years ago

Hi again, I have just pushed a new version with ID3 tagging. Let me know if you are happy with the way album artwork is handled as I was not sure if I should use the artist's profile image or the image usually presented in the playlist. For now I have gone with the latter, though it will still default to the artist's profile image if the playlist image is not present. I was also unsure if you wanted to manually set the album name, currently set to 'Traktrain', or rather extract the album name (if present) from the first downloaded track and then set the rest to be the same. Please note I have also changed over to using Bundler to handle dependencies.